[PATCH] nvmet-tcp: switch to using the crc32c library

Eric Biggers ebiggers at kernel.org
Wed Feb 26 11:01:22 PST 2025


On Wed, Feb 26, 2025 at 10:37:55AM +0100, Hannes Reinecke wrote:
> ... and it also eliminates a sporadic crash which we've seen
> where 'snd_hash' wasn't initialized when sending PDUs.
> Thanks for doing this!

I'm not sure how that could have happened, since the ahash was allocated when
'if (queue->hdr_digest || queue->data_digest)' which seemed to match the
conditions for when it was used.  But yeah, it's certainly nice to not have the
pointless allocation to worry about.

> (Note to self: check the nvme-tls code for crc32c usage ...)

I have patches for nvme-tls almost ready too.  Just been taking my time since
I've been updating all other users of "crc32" and "crc32c" in the kernel too.
And I need to decide what to do about skb_copy_and_hash_datagram_iter().

- Eric



More information about the Linux-nvme mailing list