[PATCH v26 01/20] net: Introduce direct data placement tcp offload

[Aurelien Aptel]

Paolo Abeni <pabeni at redhat.com> writes:
>> +     /* put in ulp_ddp_sk_del() */
>> +     dev_hold(netdev);
>
> You should use netdev_hold()/netdev_put() instead, with a paired reftracker.

Ok, we will pass the tracker as argument.

>>       flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);
>>       flush |= skb_cmp_decrypted(p, skb);
>> +     flush |= skb_is_ulp_crc(p) != skb_is_ulp_crc(skb);
>
> Possibly a `skb_cmp_ulp_crc()` helper would be cleaner.

Sure, we will make a skb_cmp_ulp_crc() helper.

Thanks