[PATCH 5/6] nvme-ioctl: combine alloc and map

Kanchan Joshi joshi.k at samsung.com
Tue Feb 25 01:33:04 PST 2025


On 2/24/2025 11:51 PM, Keith Busch wrote:
> +static struct request *nvme_alloc_user_request(struct request_queue *q,
> +		struct nvme_command *cmd, blk_opf_t rq_flags,
> +		blk_mq_req_flags_t blk_flags, unsigned timeout_ms, u64 ubuffer,
> +		unsigned bufflen, u64 meta_buffer, unsigned meta_len,
> +		struct io_uring_cmd *ioucmd, unsigned int flags)

Back in 2022, nvme_alloc_user_request used to take 12 arguments.
For fixed-buffer support, I added two more and got 'too many arguments' 
complaint [*]. So I did alloc/map split to trim arguments.

This patch, in itself, is going back to 2022.
But the last patch neutralizes 'too many arguments'.


[*] 
https://lore.kernel.org/linux-nvme/26490329-5b51-7334-1e2a-44edfe75d8fa@nvidia.com/



More information about the Linux-nvme mailing list