[PATCH] nvme-tcp: add basic support for the C2HTermReq PDU

[Hannes Reinecke]

On 2/24/25 15:38, Maurizio Lombardi wrote:
> On Mon Feb 17, 2025 at 11:56 AM CET, Hannes Reinecke wrote:
>> Can you add support for nvmet, too, such that we can test the patch?
>> (And maybe even a blktest script for it?)
> 
> Possible target-side implementation here.
> 
> Question is if it's acceptable to send the packet in
> blocking mode (MSG_DONTWAIT unset).
> 
I really wouldn't be doing that, as we need to terminate the queue upon
fatal error and don't really want to delay that (eg by waiting for the
transfer to finish) and

> Errors in nvmet_send_c2h_term() can be safely ignored because in any
> case we are going to perform a fatal error recovery immediately after.
> 
we don't really care about the error on sending anyway, so this is just
a 'best effort' thingie. If it works, fine, if not, fine too.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich