[PATCH 1/2] nvme: Cleanup the definition of the controller config register fields

[Damien Le Moal]

On 2025/02/13 15:23, Christoph Hellwig wrote:
> On Thu, Feb 13, 2025 at 03:07:51PM +0900, Damien Le Moal wrote:
>> I find the single enum for all the fields of the same u32 register to be a nice
>> grouping of things. But I agree that more comments would indeed be nice.
>> I can add that. But do we really need separate enums for each field ?
> 
> Ah, not really for each sub-field.  But the nvme code traditionally
> also used a single enum for multiple register or struct fields.  If
> I read this to quickly and that's not the case here all is fine.

Yep, the enum I changed is only for the CC register. Nothing else in there.
So I will just add comments.


-- 
Damien Le Moal
Western Digital Research