[RFC PATCH] nvme: replace lazy sgl warn with informational message

Christoph Hellwig hch at lst.de
Sun Feb 2 22:41:46 PST 2025


On Fri, Jan 31, 2025 at 10:54:46AM -0700, Keith Busch wrote:
> I thought this patch could remove the message because it tells you
> upfront what you'll get if you use the passthrough interface. The
> existing message tells you what you're getting once you actually try to
> use it, so they felt a bit redundant.
> 
> > I agree, I'd keep the warn_once messages.
> 
> Okay. The problem with the message is that it's a new warn, but nothing
> has really changed as far as what the driver supports, so having it at
> the "warn" level caused some alarm. Any concern if it's an info_once
> instead? I just want to avoid repeat explanations on its implications;
> I've experienced several offlist discussions about it already.

Well, we do want to warn, right?  To make sure all the current
administratative uses of passthrough switch the sysfs interfaces we
added over time.



More information about the Linux-nvme mailing list