[PATCH 14/16] nvme: use the atomic queue limits update API

Christoph Hellwig hch at lst.de
Tue Mar 26 07:52:15 PDT 2024


On Tue, Mar 26, 2024 at 03:54:49PM +0530, Kanchan Joshi wrote:
> > +	ret = queue_limits_commit_update(ns->disk->queue, &lim);
> > +	if (ret) {
> > +		blk_mq_unfreeze_queue(ns->disk->queue);
> > +		goto out;
> > +	}
> 
> Not sure if this has been discussed already.
> But do we need something that does not update the limit but still 
> releases the mutex (q->limits_lock)?
> If nvme_update_zone_info() returns error, the mutex will not be released.

It just came up in the scsi series..

Maybe we'll want a cancel_update version after all.  I thought I'd get
away without it.



More information about the Linux-nvme mailing list