[PATCH v7 1/1] nvmet: support reservation feature

Chaitanya Kulkarni chaitanyak at nvidia.com
Thu Mar 21 01:06:28 PDT 2024


On 3/20/2024 2:16 AM, Sagi Grimberg wrote:
> 
> 
> On 20/03/2024 3:59, hch at lst.de wrote:
>> On Tue, Mar 19, 2024 at 11:19:50AM +0800, Guixin Liu wrote:
>>> I am adding a per-controller percpu-ref to ns to implement
>>> preempt_and_abort, the v9 will be soon.
>> Do we need that?  For blk-mq based backends just doing a queue freeze
>> would be enough.  That doesn't work for bio based drivers yet, but I'd
>> rather improve the block layer freezing for them rather than reimplenting
>> the whole thing.
> 
> That's a neat idea, we also have file to think about though.

I failed to understand how this will work for non block device
(passthru or bio mode) backend(s). Unless there is a plan to create
similar API for non block device backhend(s) and if that turns out to be
overkill then why not go with current per-controller percpu-ref ?

-ck




More information about the Linux-nvme mailing list