[PATCH 04/14] block: use queue_limits_commit_update in queue_max_sectors_store

Chaitanya Kulkarni chaitanyak at nvidia.com
Wed Jan 31 15:18:14 PST 2024


On 1/31/24 05:03, Christoph Hellwig wrote:
> Convert queue_max_sectors_store to use queue_limits_commit_update to
> check and update the max_sectors limit and freeze the queue before
> doing so to ensure we don't have requests in flight while changing
> the limits.
>
> Note that this removes the previously held queue_lock that doesn't
> protect against any other reader or writer.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: John Garry <john.g.garry at oracle.com>
> Reviewed-by: Damien Le Moal <dlemoal at kernel.org>
> Reviewed-by: Hannes Reinecke <hare at suse.de>
> ---
>   block/blk-sysfs.c | 37 ++++++++++++-------------------------
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>

-ck




More information about the Linux-nvme mailing list