[PATCHv2 1/3] nvme-tcp: show hostnqn when connecting to tcp target

John Meneghini jmeneghi at redhat.com
Mon Jan 29 07:31:25 PST 2024


On 1/29/24 10:10, Keith Busch wrote:
> On Mon, Jan 29, 2024 at 04:18:14PM +0200, Sagi Grimberg wrote:
>>
>>> Log hostnqn when connecting to nvme target.
>>> As hostnqn could be changed, logging this information
>>> in syslog at appropriate time may help in troubleshooting.
>>
>> hostnqn is available via sysfs, why do we need to log it?
> 
> I personally haven't encountered an issue where these patches would have
> helped, but sometimes a dmesg is all you get with a bug report.

Yes, exactly. dmesg is the first place people look and often times it's the only thing available.

Reviewed-by: John Meneghini <jmeneghi at redhat.com>




More information about the Linux-nvme mailing list