[PATCH] nvme: enable retries for authentication commands

Christoph Hellwig hch at lst.de
Thu Jan 25 07:48:14 PST 2024


On Thu, Jan 25, 2024 at 08:42:10AM -0700, Jens Axboe wrote:
> On 1/25/24 6:09 AM, hare at kernel.org wrote:
> > From: Hannes Reinecke <hare at suse.de>
> > 
> > Authentication commands are normal NVMe commands, and as such
> > can return a status where NVME_SC_DNR is not set, indicating
> > that the command should be retried.
> > Rather than checking NVME_SC_DNR manually for each command completion
> > this patch adds a flag 'retry' to __nvme_submit_sync_cmd(), causing
> > the REQ_FAILFAST_DRIVER option to be cleared and the command to
> > be retried via the normal mechanism.
> 
> Can we please do this without adding Yet Another parameter to that
> function?

Heh, I wrote about the same reply a few minutes ago.  I'll try to think
what we can do instead.



More information about the Linux-nvme mailing list