[PATCH 5/8] nvme: sync the namespace scanning during ctrl start

[Max Gurtovoy]

On 24/01/2024 15:10, Sagi Grimberg wrote:
> 
>>>> @@ -4537,9 +4536,10 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
>>>>           nvme_change_uevent(ctrl, "NVME_EVENT=rediscover");
>>>>       if (ctrl->queue_count > 1) {
>>>> -        nvme_queue_scan(ctrl);
>>>> +        nvme_queue_scan_sync(ctrl);
>>>>           nvme_unquiesce_io_queues(ctrl);
>>>>           nvme_mpath_update(ctrl);
>>>> +        nvme_kick_requeue_lists(ctrl);
>>>>       }
>>>
>>> I really don't think its a good idea to block ctrl start
>>> like that.
>>
>> like how ? scan_sync ?
> 
> Yes

why not ? this is control path..
we have to make sure we issue commands to a validated namespace.