[PATCH] nvme-host: fix the updating of the firmware version

Maurizio Lombardi mlombard at redhat.com
Fri Jan 19 04:08:18 PST 2024


pá 19. 1. 2024 v 9:42 odesílatel Daniel Wagner <dwagner at suse.de> napsal:
>
> On Thu, Jan 18, 2024 at 02:21:03PM +0100, Maurizio Lombardi wrote:
> > čt 18. 1. 2024 v 13:31 odesílatel Daniel Wagner <dwagner at suse.de> napsal:
> > >
>
> > What the spec leaves undefined is what does it mean a "current fw slot"
> > with value zero, which is invalid.
>
> The valid range is 1-7 for the slot ids, that rules out the value
> zero IMO. Yeah, I agree not a thing at all.

Yeah I was just pointing to the difference here with the "next slot", the value
zero in that case is valid and defined as "The controller doesn't
provide this info".

> I suspected this but it was not mentioned in the commit message. Good to
> know that it fixes something. In this case,
>
> Reviewed-by: Daniel Wagner <dwagner at suse.de>

Thanks.

Maurizio




More information about the Linux-nvme mailing list