[PATCH 07/10] nvme-rdma: introduce NVME_RDMA_MAX_METADATA_QUEUE_SIZE definition

Max Gurtovoy mgurtovoy at nvidia.com
Wed Jan 3 14:37:38 PST 2024



On 01/01/2024 13:21, Sagi Grimberg wrote:
>>> Another completely arbitrary limit...
>>> Can this come somehow from the rdma core?
>>>
>>> If not, its not making things any worse. So its fine by me.
>>> Please comment that this limit is based on testing the devices
>>> that support PI.
>>>
>>
>> We are not changing the logic for PI controllers at all in this commit.
>>
>> I can say something like:
>>
>> "... We'll keep the maximal queue size for metadata controllers to be 
>> 128 since there are more resources that are needed for metadata 
>> operations and 128 is the optimal size found for metadata controllers 
>> based on testing.
> 
> That would be better, yes.

np.
I would like to send a new version.
any other comments for this commit beside the language for the commit 
message ?



More information about the Linux-nvme mailing list