[PATCH 03/10] nvme-fabrics: move queue size definitions to common header

[Max Gurtovoy]

On 01/01/2024 13:20, Sagi Grimberg wrote:
> 
>>>> These definitions will be used by host and target fabrics drivers. Move
>>>> them to a common place.
>>>
>>> Don't see why these should in any way be common.
>>
>> why not ?
>> why should we define these values separately for hosts and targets ?
> 
> Because the host and the target are separate systems. Don't know why
> they should share the same defines for something like this.

It is the same Linux kernel framework so why should we have different 
values ?
We have an option today to set queue_depth in nvme connect, and now 
we'll have an interface to set queue_depth in the target side as well.

do you prefer having duplication for min/max/default queue sizes for 
fabric host/target ?

> 
>>
>>>
>>>>
>>>> In the future we can introduce a common nvme-fabrics header to ease on
>>>> the maintenance of the global nvme.h header.
>>>
>>> nvme.h is the wrong place IMO.
>>
>> I've mentioned that it will be better to create 
>> include/linux/nvme-fabrics.h file for common definitions for fabrics 
>> drivers.
>> But we can do it incrementally.
> 
> I still think that nvme.h is the wrong place for this. But if others
> don't mind then fine.

nvme.h is already overloaded and splitting it to nvme-fabrics.h is 
recommended anyway, but I feel that we can do it incrementally.