[PATCH 03/10] nvme-fabrics: move queue size definitions to common header

Max Gurtovoy mgurtovoy at nvidia.com
Mon Jan 1 02:06:11 PST 2024



On 01/01/2024 11:27, Sagi Grimberg wrote:
> 
>> These definitions will be used by host and target fabrics drivers. Move
>> them to a common place.
> 
> Don't see why these should in any way be common.

why not ?
why should we define these values separately for hosts and targets ?

> 
>>
>> In the future we can introduce a common nvme-fabrics header to ease on
>> the maintenance of the global nvme.h header.
> 
> nvme.h is the wrong place IMO.

I've mentioned that it will be better to create 
include/linux/nvme-fabrics.h file for common definitions for fabrics 
drivers.
But we can do it incrementally.



More information about the Linux-nvme mailing list