[PATCH AUTOSEL 5.10 13/16] nvmet-fc: do not tack refs on tgtports from assoc

[Pavel Machek]

Hi!

> From: Daniel Wagner <dwagner at suse.de>
> 
> [ Upstream commit 1c110588dd95d21782397ff3cbaa55820b4e1fad ]
> 
> The association life time is tied to the life time of the target port.
> That means we should not take extra a refcount when creating a
> association.

I don't see this one queued for 6.1 or 6.6. What went wrong here?

Best regards,
								Pavel

> +++ b/drivers/nvme/target/fc.c
> @@ -1110,12 +1110,9 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle)
>  	if (idx < 0)
>  		goto out_free_assoc;
>  
> -	if (!nvmet_fc_tgtport_get(tgtport))
> -		goto out_ida;
> -
>  	assoc->hostport = nvmet_fc_alloc_hostport(tgtport, hosthandle);
>  	if (IS_ERR(assoc->hostport))
> -		goto out_put;
> +		goto out_ida;
>  
>  	assoc->tgtport = tgtport;
>  	assoc->a_id = idx;
> @@ -1145,8 +1142,6 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle)
>  
>  	return assoc;
>  
> -out_put:
> -	nvmet_fc_tgtport_put(tgtport);
>  out_ida:
>  	ida_simple_remove(&tgtport->assoc_cnt, idx);
>  out_free_assoc:

-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20240218/062ae5fc/attachment.sig>