[PATCH blktests v1 4/5] nvme/rc: do not issue errors when disconnecting when using fc transport

Shinichiro Kawasaki shinichiro.kawasaki at wdc.com
Wed Feb 7 02:00:49 PST 2024


On Feb 06, 2024 / 14:16, Daniel Wagner wrote:
> When running the tests with FC as transport and the udev auto connect
> enabled, discovery controllers are created and destroys while the tests

Same nit comment for "destroys".

> are running.
> 
> The cleanup code expects that all devices are under blktetsts control,

Same spell comment on "blktetsts".

> but this isn't the case. Thus filter out disconnect failures as well.
> 
> Signed-off-by: Daniel Wagner <dwagner at suse.de>
> ---
>  tests/nvme/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index ca6a284a1e25..cdfc738d3aec 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -356,7 +356,7 @@ _cleanup_nvmet() {
>  			if [[ "$transport" != "fc" ]]; then
>  				echo "WARNING: Test did not clean up ${nvme_trtype} device: ${dev}"
>  			fi
> -			_nvme_disconnect_ctrl "${dev}"
> +			_nvme_disconnect_ctrl "${dev}" 2>/dev/null
>  		fi
>  	done
>  
> -- 
> 2.43.0
> 


More information about the Linux-nvme mailing list