[PATCH v2] nvme: use dev_err() to make message more useful

Sagi Grimberg sagi at grimberg.me
Tue Dec 24 02:53:49 PST 2024



On 16/12/2024 19:44, Baruch Siach wrote:
> pr_err() produces no prefix when called from pci.c, and only generic
> prefix on other call sites. Switch to use dev_err() for more pleasant
> debugging experience.
>
> Since we now pass nvme_ctrl to nvme_find_rq() directly, nvme_find_rq()
> can figure blk_mq_tags by itself. Remove local helpers that are all
> almost identical.
>
> Suggested-by: Christoph Hellwig <hch at lst.de>
> Link: https://lore.kernel.org/r/20241212062241.GA5586@lst.de
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
>
> v2: Pass qid to nvme_find_rq() instead of tags (Christoph)

The call-sites are all printing similar errors. I'd just get rid of the 
error in
nvme_find_rq...

The change itself looks ok.. redundant, but ok...



More information about the Linux-nvme mailing list