[PATCH] nvme: use dev_err() to make message more useful
Christoph Hellwig
hch at lst.de
Wed Dec 11 23:29:18 PST 2024
On Thu, Dec 12, 2024 at 09:20:12AM +0200, Baruch Siach wrote:
> + req = nvme_find_rq(&anv->ctrl, apple_nvme_queue_tagset(anv, q), command_id);
Please avoid the overly long lines. Note that the nvme_ctrl has pointers
to the admin and io tagset, so you can actuall simply the second paramter
here by just passing a 'bool admin_queue' and remove the
apple_nvme_queue_tagset, nvme_queue_tagset, nvme_rdma_tagset and
nvme_loop_tagset helpers entirely. The TCP one still has other users
by might be worth looking into as a follow up.
More information about the Linux-nvme
mailing list