[PATCH] nvmet-loop: avoid using mutex in IO hotpath

Nilay Shroff nilay at linux.ibm.com
Mon Dec 9 09:37:53 PST 2024



On 12/9/24 13:31, Christoph Hellwig wrote:
> On Fri, Nov 29, 2024 at 04:18:33PM +0530, Nilay Shroff wrote:
>> -	xa_for_each(&ctrl->subsys->namespaces, idx, ns) {
>> +	xa_for_each_marked(&ctrl->subsys->namespaces, idx,
>> +			ns, NVMET_NS_ENABLED) {
> 
> Given that this is duplicated quite a bit, maybe add a
> nvmet_for_each_enabled_ns wrapper for it?  And also a nvmet_for_each_ns
> one that iterates all namespaces?

Yeah sure, I will add those wrappers and spin a new patch.

> Otherwise this looks good, and I really like the use of the xarray
> mark to simplify things!
> 
Thanks,
--Nilay



More information about the Linux-nvme mailing list