[PATCH] nvme: fix return type of nvme_poll()

Yongsoo Joo ysjoo at kookmin.ac.kr
Mon Dec 9 05:28:04 PST 2024


On Mon, Dec 09, 2024 at 08:58:36AM +0100, Christoph Hellwig wrote:
> On Sun, Dec 08, 2024 at 06:24:30AM +0000, Yongsoo Joo wrote:
> > I agree that all the "current" interested callers seem to expect 
> > boolean-like return values from nvme_poll(). However, the return 
> > type of both nvme_poll() and nvme_poll_cq() is int, and 
> > nvme_poll_cq() actually returns the number of processed CQEs.
> 
> Maybe add a patch to switch the poll method to return bool instead?
>
Thank you for your suggestion. I will submit a revised patch soon,
addressing the concern using the word 'fix' and the suggestion to 
return bool.


-- 




More information about the Linux-nvme mailing list