[PATCHv3 2/2] nvme: add test for writing to file-ns just after disabling it

[Nilay Shroff]

On 12/6/24 18:02, Daniel Wagner wrote:
> On Fri, Dec 06, 2024 at 04:48:08PM +0530, Nilay Shroff wrote:
>> +		# disable target namespace and write to it
>> +		echo 0 > ${ns_path}/enable
>> +		nvme write --start-block=1 --block-count=0 \
>> +			--data-size=512 --data="/dev/urandom" "$disk" 2>>"$FULL"
>>
> I haven't checked if this was already discussed. Just wondering what
> --block-count=0 is supposed to. Is it the 0 based thing?
> 
Yes it's zero based field.

# nvme write --help 
Usage: nvme write <device> [OPTIONS]

Copy from provided data buffer (default
buffer is stdin) to specified logical blocks on the given device.

Options:
  [  --verbose, -v ]                    --- Increase output verbosity
  <snip>
  [  --block-count=<NUM>, -c <NUM> ]    --- number of blocks (zeroes based)
                                            on device to access

> Rest looks good. So feel free to add
> 
> Reviewed-by: Daniel Wagner <dwagner at suse.de>
>