[PATCH] nvme-keyring: add MODULE_LICENSE()

Chaitanya Kulkarni chaitanyak at nvidia.com
Mon Oct 23 22:56:18 PDT 2023


On 10/23/23 16:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
>
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Keith Busch <kbusch at kernel.org>
> Cc: Jens Axboe <axboe at fb.com>
> Cc: Christoph Hellwig <hch at lst.de>
> Cc: Sagi Grimberg <sagi at grimberg.me>
> Cc: Hannes Reinecke <hare at suse.de>
> Cc: linux-nvme at lists.infradead.org
> ---
>   drivers/nvme/common/keyring.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
>   	key_put(nvme_keyring);
>   }
>   EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");
>

do we also need to add author ?

-ck




More information about the Linux-nvme mailing list