[PATCH] nvmet-tcp: use 'spin_lock_bh' for state_lock()

Hannes Reinecke hare at suse.de
Thu Oct 12 09:18:21 PDT 2023


On 10/12/23 17:09, Keith Busch wrote:
> On Thu, Oct 12, 2023 at 02:59:54PM +0200, Hannes Reinecke wrote:
>> nvmet_tcp_schedule_release_queue() is called from socket state
>> change callbacks, which may be called from an softirq context.
>> So use 'spin_lock_bh' to avoid a spin lock warning.
> 
> Doh, I missed you already sent this fix:
> 
>    http://lists.infradead.org/pipermail/linux-nvme/2023-August/041593.html
> 
> I can apply it on nvme-6.7, though this feels like a fix that can go in
> now. Depending on which way we go, it will cause a merge conflict for
> either stable or the next merge window. Do you have a preference? I'd
> just do 6.7 if you don't care.

Na, just apply it on top of the TLS patches. That should be fine.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman




More information about the Linux-nvme mailing list