[PATCHv3 1/2] nvme: common: make keyring and auth separate modules

[Christoph Hellwig]

On Tue, Nov 07, 2023 at 10:14:20AM -0800, Keith Busch wrote:
> From: Arnd Bergmann <arnd at arndb.de>
> 
> When only the keyring module is included but auth is not, modpost
> complains about the lack of a module license tag:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
> 
> Address this by making both modules buildable standalone,
> removing the now unnecessary CONFIG_NVME_COMMON symbol
> in the process.
> 
> Also, now that NVME_KEYRING config symbol can be either a module or
> built-in, the stubs need to check for '#if IS_ENABLED' rather than a
> simple '#ifdef'.

I know I reviewed this before, but after the whole discussion this
splitting seems rather pointless.  All that we need for a minimal
fix would be to create a new file containing nothing but the
MODULE_LICENSE statement so that it is always built.  And these
two modules would be really tiny and wasteful.