[PATCH 1/2] nvmet-rdma: avoid circular locking dependency on install_queue()

Hannes Reinecke hare at suse.de
Fri Nov 3 04:58:31 PDT 2023


On 11/3/23 10:19, Christoph Hellwig wrote:
> On Fri, Nov 03, 2023 at 09:53:05AM +0100, Hannes Reinecke wrote:
>> Retry? The DNR bit is not set, so the default action should be to retry.
>> And the idea is that this condition is a very short-lived one anyway.
>> No?
> 
> Maybe.  Best to explicitly state what is going to happen and how you
> tested it in the commit log..

Hmm. Or we just kill it.
According to 777dc82395de ("nvmet-rdma: occasionally flush ongoing 
controller teardown") this is just for reducing the memory footprint.
Wonder if we need to bother, and whether it won't be better to remove
the whole thing entirely.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare at suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg
Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman
(HRB 36809, AG Nürnberg)




More information about the Linux-nvme mailing list