[PATCH] Revert "IB/core: Fix use workqueue without WQ_MEM_RECLAIM"

Jason Gunthorpe jgg at ziepe.ca
Wed May 31 12:09:45 PDT 2023


On Mon, May 29, 2023 at 05:12:33PM +0200, Maurizio Lombardi wrote:
> út 23. 5. 2023 v 20:28 odesílatel Leon Romanovsky <leon at kernel.org> napsal:
> > > workqueue: WQ_MEM_RECLAIM nvme-wq:nvme_rdma_reconnect_ctrl_work
> > > [nvme_rdma] is flushing !WQ_MEM_RECLAIM ib_addr:process_one_req [ib_core]
> >
> > And why does nvme-wq need WQ_MEM_RECLAIM flag? I wonder if it is really
> > needed.
> 
> Adding Sagi Grimberg to cc, he probably knows and can explain it better than me.

We already allocate so much memory on these paths it is pretty
nonsense to claim they are a reclaim context. One allocation on the WQ
is not going to be the problem.

Probably this nvme stuff should not be re-using a reclaim marke dWQ
for memory allocating work like this, it is kind of nonsensical.

Jason



More information about the Linux-nvme mailing list