[RFC v2 2/3] nvme: add error logging opt-in
alan.adamson at oracle.com
alan.adamson at oracle.com
Thu Mar 30 09:24:08 PDT 2023
On 3/30/23 6:38 AM, Sagi Grimberg wrote:
>>> Is this something that we need per ctrl? My assumption is that
>>> if someone wants this, one would enable it for all controllers.
>>> Maybe this should be a modparam instead?
>>
>> Maybe both? Have the ability to set the system-wide default value
>> via modparam and sysfs to change it per ctrl?
>
> Definitely not both. If per controller setting is needed then lets do
> that, and if not, lets do a global modparam.
I think the use-case for it would be:
- debugging a problematic controller. So you would only need logging
enabled for a short time while debugging that controller.
- Some application that is sending passthrough commands to a specific
controller.
Its probably best to enable it per controller.
Alan
More information about the Linux-nvme
mailing list