[PATCH 1/9] nvme-core: use uint type for shutdown timeout

Chaitanya Kulkarni chaitanyak at nvidia.com
Sun Mar 26 16:06:45 PDT 2023


On 3/26/23 00:22, Sagi Grimberg wrote:
>
>>>>> Use consistent type unsigned int for shutdown_timeout that matches
>>>>> other timeout types.
>>>>
>>>> Does it make sense to allow shutdown timeout to be that long?
>>>>
>>>
>>
>> thinking on the same line do we really need admin and io timeout
>> values to be unsigned int (sizeof(unsigned int) = 4 bytes on
>> my machine ? as this value is in seconds 0xffffffff is way
>> to long wait to finish admin command..
>>
>> perhaps we should change it to u16 for io/admin/shudown timeout ?
>
> I think we can leave the io/admin and shutdown as they are.

okay, will send out v2 with comments addressed.

-ck




More information about the Linux-nvme mailing list