[PATCH 1/9] nvme-core: use uint type for shutdown timeout

Chaitanya Kulkarni chaitanyak at nvidia.com
Thu Mar 23 15:21:25 PDT 2023


On 3/23/23 00:56, Sagi Grimberg wrote:
>> Use consistent type unsigned int for shutdown_timeout that matches
>> other timeout types.
>
> Does it make sense to allow shutdown timeout to be that long?
>

no you are right it matches with rest of the timeout types..
we can drop this patch if you want to..

>  Also, use this oppurtunity to print default
>> timeout values in the module parameter description that saves a trip
>> to source code.
>
> Or simply reading from sys modparams, which one may do anyway.
>

that is certainly possible, with null_blk we have it in the
MODULE_PARAM_DESC() string and it turned out to be very
helpful ...

-ck




More information about the Linux-nvme mailing list