[PATCH 0/9] nvme-core: trivial cleanups
Chaitanya Kulkarni
kch at nvidia.com
Wed Mar 22 20:36:27 PDT 2023
Hi,
Small code cleanups for nvme-core and the last patch has fixing really
long argument list of __nvme_submit_sync_cmd().
Please have a closer look at patch 4 and 9.
There are no functional changes in any of these patches.
-ck
Chaitanya Kulkarni (9):
nvme-core: use uint type for shutdown timeout
nvme-core: remove unnecessary else
nvme-core: remvoe extra line at end of function
nvme-core: code cleanup for __nvme_check_ready()
nvme-core: use normal pattern
nvme-core: open code nvme_delete_ctrl_sync()
nvme-core: cleanup for nvme_set_latency_tolerance
nvme-core: remove unneacessary else
nvme-core: fix nvme_submit_sync_cmd() args
drivers/nvme/host/auth.c | 13 ++-
drivers/nvme/host/core.c | 158 +++++++++++++++++++++---------------
drivers/nvme/host/fabrics.c | 60 +++++++++++---
drivers/nvme/host/nvme.h | 16 +++-
4 files changed, 163 insertions(+), 84 deletions(-)
This series is passing the blktests for nvme-loop and nvme-tcp :-
blktests (master) # ./check nvme
nvme/002 (create many subsystems and test discovery) [passed]
runtime 19.504s ... 19.508s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
runtime 10.087s ... 10.091s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
runtime 1.440s ... 1.476s
nvme/005 (reset local loopback target) [passed]
runtime 1.798s ... 1.814s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
runtime 0.061s ... 0.053s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
runtime 0.032s ... 0.031s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
runtime 1.458s ... 1.455s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
runtime 1.440s ... 1.433s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 71.351s ... 82.214s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
runtime 73.525s ... 70.006s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 77.108s ... 77.670s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
runtime 67.936s ... 67.830s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
runtime 4.152s ... 4.324s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
runtime 3.710s ... 3.724s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
runtime 13.086s ... 13.120s
nvme/017 (create/delete many file-ns and test discovery) [passed]
runtime 13.287s ... 13.261s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
runtime 1.449s ... 1.456s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
runtime 1.435s ... 1.455s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
runtime 1.422s ... 1.419s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
runtime 1.430s ... 1.445s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
runtime 1.758s ... 1.754s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
runtime 1.456s ... 1.457s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
runtime 1.416s ... 1.432s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
runtime 1.426s ... 1.422s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
runtime 1.447s ... 1.430s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
runtime 1.423s ... 1.418s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
runtime 1.434s ... 1.416s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
runtime 1.557s ... 1.548s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
runtime 0.204s ... 0.199s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
runtime 3.906s ... 4.045s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
runtime 0.011s ... 0.012s
nvme/040 (test nvme fabrics controller reset/disconnect operation during I/O) [passed]
runtime 7.869s ... 7.982s
nvme/041 (Create authenticated connections) [passed]
runtime 0.711s ... 0.746s
nvme/042 (Test dhchap key types for authenticated connections) [passed]
runtime 4.567s ... 4.589s
nvme/043 (Test hash and DH group variations for authenticated connections) [passed]
runtime 3.162s ... 6.974s
nvme/044 (Test bi-directional authentication) [passed]
runtime 1.724s ... 1.704s
nvme/045 (Test re-authentication) [passed]
runtime 3.920s ... 3.947s
blktests (master) # nvme_trtype=tcp ./check nvme
nvme/002 (create many subsystems and test discovery) [not run]
runtime 19.508s ...
nvme_trtype=tcp is not supported in this test
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
runtime 10.091s ... 10.089s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
runtime 1.476s ... 1.124s
nvme/005 (reset local loopback target) [passed]
runtime 1.814s ... 1.192s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
runtime 0.053s ... 0.054s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
runtime 0.031s ... 0.035s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
runtime 1.455s ... 1.133s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
runtime 1.433s ... 1.130s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 82.214s ... 89.073s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
runtime 70.006s ... 78.218s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 77.670s ... 75.592s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
runtime 67.830s ... 73.434s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
runtime 4.324s ... 3.913s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
runtime 3.724s ... 3.564s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [not run]
runtime 13.120s ...
nvme_trtype=tcp is not supported in this test
nvme/017 (create/delete many file-ns and test discovery) [not run]
runtime 13.261s ...
nvme_trtype=tcp is not supported in this test
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
runtime 1.456s ... 1.128s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
runtime 1.455s ... 1.148s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
runtime 1.419s ... 1.113s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
runtime 1.445s ... 1.104s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
runtime 1.754s ... 1.151s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
runtime 1.457s ... 1.132s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
runtime 1.432s ... 1.113s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
runtime 1.422s ... 1.105s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
runtime 1.430s ... 1.116s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
runtime 1.418s ... 1.127s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
runtime 1.416s ... 1.109s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
runtime 1.548s ... 1.239s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
runtime 0.199s ... 0.126s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
runtime 4.045s ... 0.791s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
runtime 0.012s ... 0.014s
nvme/040 (test nvme fabrics controller reset/disconnect operation during I/O) [passed]
runtime 7.982s ... 7.153s
nvme/041 (Create authenticated connections) [passed]
runtime 0.746s ... 0.402s
nvme/042 (Test dhchap key types for authenticated connections) [passed]
runtime 4.589s ... 2.546s
nvme/043 (Test hash and DH group variations for authenticated connections) [passed]
runtime 6.974s ... 0.691s
nvme/044 (Test bi-directional authentication) [passed]
runtime 1.704s ... 1.122s
nvme/045 (Test re-authentication) [passed]
runtime 3.947s ... 3.782s
blktests (master) #
--
2.29.0
More information about the Linux-nvme
mailing list