[PATCH 1/1] nvme-tcp: fence TCP socket on transport error

[Chris Leech]

On Tue, Mar 21, 2023 at 1:30 AM Sagi Grimberg <sagi at grimberg.me> wrote:
> > +     if (!queue->rd_enabled) {
> > +             /* io_work or polling happening after receive error
> > +              * waiting on error recovery
> > +              */
> > +             return -EFAULT;
> > +     }
>
> I think we can drop the comment, the code is somewhat self-explanatory,
> if read is not enabled, we shouldn't try and read from the socket.
>
>         if (!queue->rd_enabled)
>                 return -EFAULT;

Sure, and as it's an error check in the data path I'll add an unlikely hint.

- Chris