more nvmet Identify fixups

Chaitanya Kulkarni chaitanyak at nvidia.com
Thu Mar 16 00:14:48 PDT 2023


On 3/15/23 15:52, Chaitanya Kulkarni wrote:
> On 3/15/23 07:20, Christoph Hellwig wrote:
>> Hi all,
>>
>> here is two more patches on top of the work from Damien that I've
>> applied to nvme-6.4.
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
>
> -ck
>
>

I think you need this on the top of this,
I believe it will result in error, please check:-

diff --git a/drivers/nvme/target/admin-cmd.c 
b/drivers/nvme/target/admin-cmd.c
index 4ee30a4da509..afdf69f92599 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -692,7 +692,7 @@ static void nvmet_execute_identify(struct nvmet_req 
*req)
                 return;
         case NVME_ID_CNS_NS_DESC_LIST:
                 nvmet_execute_identify_desclist(req);
-               break;
+               return;
         case NVME_ID_CNS_CS_NS:
                 switch (req->cmd->identify.csi) {
                 case NVME_CSI_NVM:

-ck




More information about the Linux-nvme mailing list