[PATCH 0/5] Fix nvme target identify command handling

[Chaitanya Kulkarni]

On 3/15/23 03:59, Damien Le Moal wrote:
> These patches fix compliance of the target identify commands. The last
> patch is only a cleanup and does not introduce any functional change.
>
>

Looks good, I've tested with blktests nvme-loop
see [1].

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
Tested-by: Chaitanya Kulkarni <kch at nvidia.com>

-ck

[1]
blktests (master) # ./check nvme
nvme/002 (create many subsystems and test discovery) [passed]
     runtime  19.514s  ...  19.093s
nvme/003 (test if we're sending keep-alives to a discovery controller) 
[passed]
     runtime  10.098s  ...  10.087s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
     runtime  1.439s  ...  1.457s
nvme/005 (reset local loopback target) [passed]
     runtime  1.804s  ...  1.812s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
     runtime  0.061s  ...  0.059s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
     runtime  0.031s  ...  0.034s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
     runtime  1.487s  ...  1.485s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
     runtime  1.433s  ...  1.421s
nvme/010 (run data verification fio job on NVMeOF block device-backed 
ns) [passed]
     runtime  82.421s  ...  87.332s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
     runtime  81.191s  ...  80.243s
nvme/012 (run mkfs and data verification fio job on NVMeOF block 
device-backed ns) [passed]
     runtime  79.530s  ...  75.895s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed 
ns) [passed]
     runtime  77.714s  ...  68.238s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
     runtime  4.476s  ...  4.376s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
     runtime  3.735s  ...  3.807s
nvme/016 (create/delete many NVMeOF block device-backed ns and test 
discovery) [passed]
     runtime  12.765s  ...  13.068s
nvme/017 (create/delete many file-ns and test discovery) [passed]
     runtime  12.961s  ...  13.194s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
     runtime  1.448s  ...  1.431s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
     runtime  1.472s  ...  1.460s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
     runtime  1.422s  ...  1.410s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
     runtime  1.430s  ...  1.419s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
     runtime  1.764s  ...  1.746s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
     runtime  1.449s  ...  1.457s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
     runtime  1.422s  ...  1.420s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
     runtime  1.431s  ...  1.414s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
     runtime  1.416s  ...  1.417s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
     runtime  1.426s  ...  1.456s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
     runtime  1.438s  ...  1.424s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
     runtime  1.564s  ...  1.558s
nvme/030 (ensure the discovery generation counter is updated 
appropriately) [passed]
     runtime  0.221s  ...  0.203s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) 
[passed]
     runtime  3.939s  ...  3.890s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
     runtime  0.013s  ...  0.013s
nvme/040 (test nvme fabrics controller reset/disconnect operation during 
I/O) [passed]
     runtime  7.989s  ...  7.961s
nvme/041 (Create authenticated connections) [passed]
     runtime  0.734s  ...  0.730s
nvme/042 (Test dhchap key types for authenticated connections) [passed]
     runtime  4.723s  ...  4.694s
nvme/043 (Test hash and DH group variations for authenticated 
connections) [passed]
     runtime  6.921s  ...  6.937s
nvme/044 (Test bi-directional authentication) [passed]
     runtime  1.710s  ...  1.707s
nvme/045 (Test re-authentication) [passed]
     runtime  3.963s  ...  3.997s