[PATCH 4/5] nvmet: Fix I/O Command Set specific Identify Controller

Christoph Hellwig hch at lst.de
Wed Mar 15 06:38:21 PDT 2023


> 1) Renaming nvmet_execute_identify_cns_cs_ctrl() to
>    nvmet_execute_identify_cns_cs_ctrl_zns() to continue handling the
>    ZNS command set as is.

I think nvmet_execute_identify_ctrl_cs_zns might be a better name.

> 2) Introduce nvmet_execute_identify_cns_cs_ctrl() helper to handle the
>    NVM command set, returning a zero filled nvme_id_ctrl_nvm data
>    structure.

and this might better be named nvmet_execute_identify_ctrl_cs.

As the _cns in all these and the Identify Namespace variants is
rather redundant.

Otherwise this looks good to me (and I can fix up the naming when
applying the series)



More information about the Linux-nvme mailing list