[PATCH] nvme: zns: limit max_zone_append by max_segments

Damien Le Moal dlemoal at kernel.org
Mon Jul 31 07:33:02 PDT 2023


On 7/31/23 23:26, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 11:12:43PM +0900, Damien Le Moal wrote:
>> max zone append sectors limit indicates the maximum size of a zone append BIO
>> that can be built without ever needing splitting.
>>
>> So if we fix the zns limit, zonefs does not really need a fix, eventhough the
>> code would be a little weird as-is.
> 
> You still need to fix splitting due to I/O layout and not just size.
> 
> E.g. if your do a writev() with two non-page aligned buffers (you'll
> probably need a arm64 or power box to trigger it), you need to split
> the bio even if it trivially fits into the size limit.  Similar for
> things like max_segment_size.

Good point. So fix needed.


-- 
Damien Le Moal
Western Digital Research




More information about the Linux-nvme mailing list