[PATCH v1 1/2] nvme: drop multipath config option

Keith Busch kbusch at kernel.org
Wed Jul 19 04:38:55 PDT 2023


On Wed, Jul 19, 2023 at 01:13:18PM +0200, Daniel Wagner wrote:
> On Wed, Jul 19, 2023 at 12:04:50PM +0200, Keith Busch wrote:
> > From my reading of this message, I thought the intention was that this
> > driver will eventually replace it with a:
> > 
> >   			goto out_put_ns_head;
> 
> This would obviously make the PowerPath module unhappy. Sure, I am aware of our
> upstream policy so I wont argue.
> 
> > instead of letting the namespace become visible for some unsupported
> > mode. The warning was to give people a chance to migrate off whatever
> > unsupported setup they were using, not a deadline for when the warning
> > dissappears.
> 
> I assume this means the dm-multipath setups? If so, I understand the motivation
> but do we really have to burn the bridge here? It's not that we have additional
> code or maintaince overhead, except the module parameter multipath.

Yeah, dm-mpath is such a setup this was intended to prevent, as well as
out-of-tree alternatives. Not that I advocating one way or another at
this point; I'm just trying to set the context for why this message
exists for discussing your patchset.

I'm curious why a proprietary module is even used, though. Is the
driver's native handling doing something undesirable, or is this to
cater to some vendor specific behavior outside the spec? If the former,
I'd like to understand the problem and see if there's something we can
improve.



More information about the Linux-nvme mailing list