[PATCHv2] nvme: always initialize known command effects

Christoph Hellwig hch at lst.de
Mon Jan 23 10:02:19 PST 2023


On Mon, Jan 23, 2023 at 10:42:45AM -0700, Keith Busch wrote:
> xarray lookups are pretty slow in comparison, though. This is in a fast
> path now, so I think we need to keep caching it.

Is it?

> Alternatively, we could replace the xarray with a normal array sized to
> highest seen CSI. Realisitically, I don't think we'll see a CSI higher
> than 3 any time soon, so it wouldn't take up much space.

The problem is that we lose the extensibility to arbitrary command
sets for the ng devices.  So if the xarray performance is a problem
let's not waste any time on this idea.



More information about the Linux-nvme mailing list