[PATCH] nvme-tcp: check for allocated queue in nvme_tcp_get_address()

Hannes Reinecke hare at suse.de
Tue Feb 7 06:55:48 PST 2023


We need to check if the queue is allocated, otherwise we get
a kernel crash as 'queue->sock' is not allocated.

Signed-off-by: Hannes Reinecke <hare at suse.de>
---
 drivers/nvme/host/tcp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 4ddf3e7b252a..487ea3e8b6c4 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2859,6 +2859,9 @@ static int nvme_tcp_get_address(struct nvme_ctrl *ctrl, char *buf, int size)
 	struct sockaddr_storage src_addr;
 	int ret, len;
 
+	if (!test_bit(NVME_TCP_Q_ALLOCATED, &queue->flags))
+		return -EINVAL;
+
 	len = nvmf_get_address(ctrl, buf, size);
 
 	ret = kernel_getsockname(queue->sock, (struct sockaddr *)&src_addr);
-- 
2.35.3




More information about the Linux-nvme mailing list