[PATCHv2] nvme-pci: enhance timeout kernel log

[Max Gurtovoy]

On 19/12/2023 18:15, Keith Busch wrote:
> On Tue, Dec 19, 2023 at 06:09:23PM +0200, Max Gurtovoy wrote:
>>
>>
>> On 19/12/2023 16:15, Sagi Grimberg wrote:
>>>
>>>>> -             "I/O %d QID %d timeout, completion polled\n",
>>>>> +             "I/O tag %d QID %d timeout, completion polled\n",
>>>>
>>>> Q: should we use the Linux term tag or the NVMe term command ID
>>>> (or command_id) ?  I don't really care, just thinking out loud.
>>>
>>> I was fine with neither tbh, but tag is better than command_id I
>>> think.
>>>
>>
>> In the current Keith code it is actually the tag.
>> If you would like to print the cid please use: nvme_cid(req).
>>
>> I guess the cid will be the useful value that we can compare to the
>> wireshark or the target prints.
> 
> Yes! This currently prints the "tag" from blk-mq. I can change it to
> print the encoded command_id in the SQE. Or both!

I tend to say command_id is more interesting. So better use the option 
of cid or both.

Can you please align all the timeout functions in different transports 
to print same value (tag or cid) ? each transport today prints different 
values. For example tcp prints cid and rdma prints tag :)