[PATCHv2] nvme-pci: enhance timeout kernel log

[Christoph Hellwig]

On Mon, Dec 18, 2023 at 02:46:33PM -0800, Keith Busch wrote:
> -			 "I/O %d QID %d timeout, completion polled\n",
> +			 "I/O tag %d QID %d timeout, completion polled\n",

Q: should we use the Linux term tag or the NVMe term command ID
(or command_id) ?  I don't really care, just thinking out loud.

> +	opcode = nvme_req(req)->cmd->common.opcode;
>  	if (!nvmeq->qid || iod->aborted) {
>  		dev_warn(dev->ctrl.device,
> -			 "I/O %d QID %d timeout, reset controller\n",
> -			 req->tag, nvmeq->qid);
> +			 "I/O tag %d (opcode:%s %d) QID %d timeout, reset controller\n",
> +			 req->tag, nvme_opcode_str(nvmeq->qid, opcode, 0),
> +			 opcode, nvmeq->qid);

space after the ":" ?

> +		 "I/O tag %d (opcode:%s %d) QID %d timeout, aborting req_op:%s(%u) size:%u\n",
> +		 req->tag, nvme_get_opcode_str(opcode), opcode, nvmeq->qid,
> +		 blk_op_str(req_op(req)), req_op(req), blk_rq_bytes(req));

Same.