[PATCH 1/5] nvmet: fix wrong error handling approach in nvmet_install_queue

Guixin Liu kanie at linux.alibaba.com
Wed Dec 13 04:49:52 PST 2023


在 2023/12/13 16:43, Christoph Hellwig 写道:
> On Wed, Dec 13, 2023 at 02:32:48PM +0800, Guixin Liu wrote:
>> In the nvmet_install_queue() function, do not set the ctrl pointer
>> to NULL if the sqsize check fails.
> Can you explain why it is wrong, and why not doing it is desirable?

If a queue which is already connected, then receive a connect cmd with 
sqsize=0, it will set the

req->sq->ctrl to NULL and break the queue.




More information about the Linux-nvme mailing list