[PATCHv3 0/2] nvmet: avoid circular locking warning

Shinichiro Kawasaki shinichiro.kawasaki at wdc.com
Mon Dec 11 04:44:00 PST 2023


On Dec 08, 2023 / 13:53, hare at kernel.org wrote:
> From: Hannes Reinecke <hare at suse.de>
> 
> nvmet-rdma and nvmet-tcp trigger a circular locking warning when
> tearing down; reason is a call to 'flush_workqueue' when creating
> a new controller which tries to cover for the fact that old controller
> instances might be in the process of tearing down.
> However, this is pure speculation as we don't know (and don't check)
> if there really _are_ controllers in shutdown.
> And even if there were, that should be short-lived, and would have been
> resolved by connecting just a tad later.
> So this patch returns 'controller busy' if we really find ourselves in this
> situation, allowing the caller to reconnect later.

Thanks Hannes. I reconfirmed the patches avoid the circular lockdep WARN with
rdma and tcp transports using v6.7-rc5 kernel. And I observed no regression in
my blktests runs. Looks good.


More information about the Linux-nvme mailing list