[PATCH] nvme-ioctl: move capable() admin check to the end

Keith Busch kbusch at kernel.org
Mon Dec 4 07:42:55 PST 2023


On Mon, Dec 04, 2023 at 03:35:52PM +0100, Christoph Hellwig wrote:
> On Mon, Dec 04, 2023 at 07:33:01AM -0700, Keith Busch wrote:
> > On Mon, Dec 04, 2023 at 09:30:34AM +0100, Christoph Hellwig wrote:
> > > On Thu, Nov 30, 2023 at 12:19:19PM -0800, Keith Busch wrote:
> > > > From: Keith Busch <kbusch at kernel.org>
> > > > 
> > > > This can be an expensive call on some distros.
> > > 
> > > Huh?  How would a distro matter for kernel code?
> > 
> > Security monitoring: audit, LSM, and bpf hooks all make this function
> > undesirable for a fast path check.
> 
> So what matters is kernel configuration, not "distro".

Yeah, fair enough: the overhead comes from the kernel config. So just
update the change log and good to go?



More information about the Linux-nvme mailing list