[PATCH blktests] nvme/rc: fix nvme device readiness check after _nvme_connect_subsys

Yi Zhang yi.zhang at redhat.com
Wed Aug 16 21:23:35 PDT 2023


On Wed, Aug 16, 2023 at 8:11 PM Shinichiro Kawasaki
<shinichiro.kawasaki at wdc.com> wrote:
>
> On Aug 14, 2023 / 12:37, Sagi Grimberg wrote:
> >
> > > The helper function _nvme_connect_subsys() creates a nvme device. It may
> > > take some time after the function call until the device gets ready for
> > > I/O. So it is expected that the test cases call _find_nvme_dev() after
> > > _nvme_connect_subsys() before I/O. _find_nvme_dev() returns the path of
> > > the created device, and it also waits for uuid and wwid sysfs attributes
> > > of the created device get ready. This wait works as the wait for the
> > > device I/O readiness.
> >
> > Shouldn't this call udevadm --settle or something?
>
> Ah, it will be more stable to add "udevadm settle" before the readiness check.
> Will add it.
>
Yes, I just tried to add "udevadm --settle" and it works well.

-- 
Best Regards,
  Yi Zhang




More information about the Linux-nvme mailing list