[PATCH v12 11/26] nvme-tcp: Add modparam to control the ULP offload enablement

Aurelien Aptel aaptel at nvidia.com
Thu Aug 10 07:50:12 PDT 2023


Sagi Grimberg <sagi at grimberg.me> writes:
>> +static bool ulp_offload;
>> +module_param(ulp_offload, bool, 0644);
>> +MODULE_PARM_DESC(ulp_offload, "Enable or disable NVMeTCP ULP support");
>
> the name is strange.
> maybe call it ddp_offload?
> and in the description spell it as "direct data placement"

Sure.

> This patch should be folded to the control path. No reason for it to
> stand on its own I think.

Sure, we will fold it.

Thanks



More information about the Linux-nvme mailing list