[PATCH libnvme 3/1] fabrics: add notify_rediscover parameter

Daniel Wagner dwagner at suse.de
Thu Sep 8 23:58:46 PDT 2022


On Wed, Sep 07, 2022 at 05:24:10PM +0300, Sagi Grimberg wrote:
> @@ -481,6 +482,8 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
>  	    (hostid && add_argument(argstr, "hostid", hostid)) ||
>  	    (discover && !discovery_nqn &&
>  	     add_bool_argument(argstr, "discovery", true)) ||
> +	     add_bool_argument(argstr, "notify_rediscover",
> +			       cfg->notify_rediscover) ||

If notify_rediscover is not supported by the kernel, wouldn't this end
up with an EINVAL when we try to connect? I thought we need to make this
conditional.



More information about the Linux-nvme mailing list