[PATCH for-next v5 4/4] nvme: wire up fixed buffer support for nvme passthrough

Chaitanya Kulkarni chaitanyak at nvidia.com
Wed Sep 7 07:51:31 PDT 2022


>   	req = nvme_alloc_user_request(q, cmd, ubuffer, bufflen, meta_buffer,
> -			meta_len, meta_seed, &meta, timeout, vec, 0, 0);
> +			meta_len, meta_seed, &meta, timeout, vec, 0, 0, NULL, 0);
>   	if (IS_ERR(req))
>   		return PTR_ERR(req);

14 Arguments to the function!

Kanchan, I'm not pointing out to this patch it has happened over
the years, I think it is high time we find a way to trim this
down.

Least we can do is to pass a structure member than 14 different
arguments, is everyone okay with it ?

-ck



More information about the Linux-nvme mailing list