[PATCH 1/2] nvme-auth: allocate authentication buffer only during transaction

Christoph Hellwig hch at lst.de
Sun Oct 30 00:52:30 PDT 2022


> +
> +	/*
> +	 * Allocate a large enough buffer for the entire negotiation:
> +	 * 4k should be enough to ffdhe8192.

should or is?

> +	chap->buf_size = 4096;

why do we even need the buf_size member if it is constant?

> +	chap->buf = kzalloc(chap->buf_size, GFP_KERNEL);

I think this needs to be GFP_NOIO as we can hit this during a reconnect.



More information about the Linux-nvme mailing list